Stream: git-wasmtime

Topic: wasmtime / PR #6409 Don't cancel the github actions run o...

Wasmtime GitHub notifications bot (May 18 2023 at 15:19):

alexcrichton opened PR #6409 from alexcrichton:no-cancel-windows to bytecodealliance:main:

Currently all the jobs in GitHub Actions are configured to cancel the entire run if any of them fail. This is similar to fail-fast: true but that can't be used because the jobs aren't all part of the same matrix. The original goal for this was to save CI time on the merge queue where if something failed it should get out of the merge queue quickly instead of waiting for all other jobs to succeed and then report the one quick failure.

This seems to run into an issue, though, where if a Windows builder fails then running cancellation will instead mark the Windows builder as cancelled instead of failed. This can be confusing for test failures because nothing looks obvious and each log needs to be manually pored over.

To help address this the commit here disables auto-cancellation of the "test" matrix of jobs, re-enabling fail-fast: true at the same time. This way test if a test job fails it won't actually cancel everything else so everything else will run to completion, but given that tests are typically the longest part of the build that's hopefully ok.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 18 2023 at 15:19):

alexcrichton has marked PR #6409 as ready for review.

Wasmtime GitHub notifications bot (May 18 2023 at 15:19):

alexcrichton requested elliottt for a review on PR #6409.

Wasmtime GitHub notifications bot (May 18 2023 at 15:19):

alexcrichton requested wasmtime-default-reviewers for a review on PR #6409.

Wasmtime GitHub notifications bot (May 18 2023 at 16:27):

elliottt submitted PR review:

Looks good to me!

Wasmtime GitHub notifications bot (May 18 2023 at 17:11):

alexcrichton merged PR #6409.

Last updated: Nov 22 2024 at 16:03 UTC