Stream: git-wasmtime

Topic: wasmtime / PR #6406 Fold guest profiling flags into `--pr...

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 00:51):

jameysharp opened PR #6406 from jameysharp:profiling-flags to bytecodealliance:release-9.0.0:

This commit removes the --profile-guest and --profile-guest-interval CLI flags and folds them into the preexisting --profile flag. Specifying guest profiling can now be done with --profile guest which has a default path/interval to write to. The path/interval can be configured with --profile guest,path.json and --profile guest,path.json,10ms.

This is a backport of CLI flag changes which landed after the release-9.0.0 branch forked. The removed flags have never been in a previous release so I'd like for them to not go out in 9.0 either, to avoid having one release that's different before the new syntax appears in 10.0.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 00:51):

jameysharp requested fitzgen for a review on PR #6406.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 00:51):

jameysharp requested wasmtime-core-reviewers for a review on PR #6406.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 00:53):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 14:08):

alexcrichton merged PR #6406.

Last updated: Nov 22 2024 at 16:03 UTC