Wasmtime GitHub notifications bot (May 18 2023 at 00:22): Wasmtime GitHub notifications bot (May 18 2023 at 00:22):pchickey opened PR #6404 from bytecodealliance:pch/fd_readdir_test to bytecodealliance:main:
This is an unnecessary restriction: applications shouldn't be relying on any ordering of preview1 fds, besides that other files are not found in the stdio range.
This behavior changed with the introduction of the component adapter, but I am making a separate PR to edit the test rather than make it part of #6391.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 18 2023 at 00:23):pchickey requested sunfishcode for a review on PR #6404.
Wasmtime GitHub notifications bot (May 18 2023 at 00:24):pchickey has marked PR #6404 as ready for review.
Wasmtime GitHub notifications bot (May 18 2023 at 00:24):pchickey requested itsrainy for a review on PR #6404.
Wasmtime GitHub notifications bot (May 18 2023 at 00:24):pchickey requested wasmtime-core-reviewers for a review on PR #6404.
Wasmtime GitHub notifications bot (May 18 2023 at 17:07):sunfishcode submitted PR review:
This is something where, if we wanted to, we could provide more guarantees about file descriptor numbering, but I don't think we want to. It'll always be error-prone for application code to be aware of numeric relationships between file descriptors.
Wasmtime GitHub notifications bot (May 18 2023 at 17:44):pchickey merged PR #6404.
Last updated: Oct 23 2024 at 20:03 UTC