Stream: git-wasmtime

Topic: wasmtime / PR #6398 Bump regalloc2

Wasmtime GitHub notifications bot (May 17 2023 at 16:36):

elliottt opened PR #6398 from elliottt:trevor/regalloc2-0.9.0 to bytecodealliance:main:

Bump the regalloc2 dependency to 0.9.0, to pull in some new perf improvements.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 17 2023 at 16:36):

elliottt requested wasmtime-default-reviewers for a review on PR #6398.

Wasmtime GitHub notifications bot (May 17 2023 at 16:36):

elliottt requested abrown for a review on PR #6398.

Wasmtime GitHub notifications bot (May 17 2023 at 16:40):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (May 17 2023 at 16:48):

elliottt updated PR #6398.

Wasmtime GitHub notifications bot (May 17 2023 at 16:48):

elliottt requested wasmtime-compiler-reviewers for a review on PR #6398.

Wasmtime GitHub notifications bot (May 17 2023 at 17:00):

elliottt created PR review comment:

The additional moves here are expected, as we're now creating overlapping liveranges in regalloc2-0.9.0. Follow-on work will involve removing these, but local profiling of benchmarks like bz2, pulldown-cmark, and spidermonkey was not showing any performance regression.

Wasmtime GitHub notifications bot (May 17 2023 at 17:02):

cfallin submitted PR review:

Very excited to have this! A few extra moves are OK for now, as you say, since we know where they come from and how to address them, and overall this is a quite good compile-time win.

Wasmtime GitHub notifications bot (May 17 2023 at 21:29):

elliottt updated PR #6398.

Wasmtime GitHub notifications bot (May 17 2023 at 21:30):

elliottt updated PR #6398.

Wasmtime GitHub notifications bot (May 17 2023 at 23:04):

elliottt merged PR #6398.

Last updated: Nov 22 2024 at 17:03 UTC