Stream: git-wasmtime

Topic: wasmtime / PR #6394 Update wasm-tools crates to latest ve...

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 01:18):

itsrainy opened PR #6394 from bytecodealliance:rainy/wasm-tools-update to bytecodealliance:main:

This included stubbing out unimplemented GC-related things and updating coredump generation to include the coredump spec changes.

This is to unblock https://github.com/bytecodealliance/wasmtime/pull/6385#issuecomment-1550247560, where @pchickey is running into some duplicate dependencies issues.

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 01:18):

itsrainy requested fitzgen for a review on PR #6394.

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 01:18):

itsrainy requested wasmtime-core-reviewers for a review on PR #6394.

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 01:18):

itsrainy requested wasmtime-compiler-reviewers for a review on PR #6394.

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 01:18):

itsrainy requested wasmtime-default-reviewers for a review on PR #6394.

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 01:21):

itsrainy updated PR #6394.

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 01:26):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 01:26):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 01:26):

alexcrichton created PR review comment:

Mind binding this as gc and asserting it's false down below (like memory_control)? We'll want to turn this on eventually and we won't want to forget to add handling here.

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 01:26):

alexcrichton created PR review comment:

Should the modulenames set be deferred until the frame -> instance -> module mapping can be created? Otherwise there isn't anything pointing to the module names I think?

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 01:28):

itsrainy created PR review comment:

Yeah I debated leaving that out, since it's essentially the same deal as instances. I'll remove it.

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 01:32):

itsrainy updated PR #6394.

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 03:35):

pchickey merged PR #6394.

Last updated: Nov 22 2024 at 17:03 UTC