Wasmtime GitHub notifications bot (May 16 2023 at 23:00): Wasmtime GitHub notifications bot (May 16 2023 at 23:00):jameysharp opened PR #6393 from jameysharp:guest-profiler-docs to bytecodealliance:main:
This isn't nearly as detailed as the other profiling chapters but I'm struggling to figure out what's important to say. I'd welcome feedback, although of course we can merge this and fill in details later.
This documentation reflects the changes merged in #6362, but that merged after the 9.0 branch was created. Perhaps we should backport that PR to 9.0 so the older CLI flags never appear in a release?
Wasmtime GitHub notifications bot (May 16 2023 at 23:01):jameysharp requested pchickey for a review on PR #6393.
Wasmtime GitHub notifications bot (May 16 2023 at 23:01):jameysharp requested wasmtime-default-reviewers for a review on PR #6393.
Wasmtime GitHub notifications bot (May 17 2023 at 02:25):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (May 17 2023 at 02:25):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (May 17 2023 at 02:25):alexcrichton created PR review comment:
Mind rewording the seconds around here so the list here can be a 3-bullet list with perf/vtune/guest profiling? I suspect many will scan over this page, see two bullets, and deduce there's two means of profiling Wasmtime. I'm sure many more yet will read further and realize there's a third, but having them all in one organized bulleted list I think makes sense (with all the existing commentary about which is appropriate of course)
Wasmtime GitHub notifications bot (May 17 2023 at 18:47):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (May 17 2023 at 18:47):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (May 17 2023 at 18:47):fitzgen created PR review comment:
This should maybe mention that you can load the profile in perf.firefox.com? Would be nice to include a screenshot as well.
Wasmtime GitHub notifications bot (May 17 2023 at 21:58):jameysharp updated PR #6393.
Wasmtime GitHub notifications bot (May 17 2023 at 21:59):jameysharp created PR review comment:
It definitely should mention that. Also, it does mention it, on line 5. :grin:
A screenshot or two is a good idea but I'm not feeling up to doing that right this moment, so I'd like to merge without it.
Wasmtime GitHub notifications bot (May 17 2023 at 22:16):jameysharp created PR review comment:
I think it's useful to have the distinction and separation between native and guest profilers, but I've added a bullet point to direct people to keep reading; do you think that takes care of it?
Wasmtime GitHub notifications bot (May 17 2023 at 22:19):alexcrichton submitted PR review:
:+1:
Wasmtime GitHub notifications bot (May 17 2023 at 22:59):jameysharp merged PR #6393.
Wasmtime GitHub notifications bot (May 18 2023 at 01:49):fitzgen created PR review comment:
Lol whoops don’t know how I missed that
Last updated: Nov 22 2024 at 16:03 UTC