pchickey opened PR #6391 from pchickey:pch/merge_preview2_impl
to bytecodealliance:main
.
pchickey edited PR #6391.
pchickey edited PR #6391:
WIP: Currently based on #6385
Third task in #6370
This PR lands preview2-prototyping's Wasi Preview 2 implementation inside
wasmtime_wasi::preview2
.python3 ~/Downloads/git-filter-repo.py --path host --path wasi-common --path test-programs
And then merging wasmtime's
pch/test_programs
@87fedb59d6dcf6081285bf390ccf8b5194eaff2c in with --allow-unrelated-histories.
pchickey updated PR #6391.
pchickey updated PR #6391.
pchickey updated PR #6391.
pchickey updated PR #6391.
pchickey updated PR #6391.
pchickey updated PR #6391.
pchickey updated PR #6391.
pchickey updated PR #6391.
pchickey edited PR #6391:
Third task in #6370
This PR lands preview2-prototyping's Wasi Preview 2 implementation inside
wasmtime_wasi::preview2
.Needs https://github.com/bytecodealliance/wasmtime/pull/6404 to pass all tests.
python3 ~/Downloads/git-filter-repo.py --path host --path wasi-common --path test-programs
And then merging wasmtime's
pch/test_programs
@87fedb59d6dcf6081285bf390ccf8b5194eaff2c in with --allow-unrelated-histories.
alexcrichton created PR review comment:
oh man blast from the past
pchickey updated PR #6391.
pchickey updated PR #6391.
pchickey has marked PR #6391 as ready for review.
pchickey requested jameysharp for a review on PR #6391.
pchickey requested wasmtime-core-reviewers for a review on PR #6391.
pchickey requested wasmtime-default-reviewers for a review on PR #6391.
pchickey edited PR #6391:
Third task in #6370
This PR lands preview2-prototyping's Wasi Preview 2 implementation inside
wasmtime_wasi::preview2
.python3 ~/Downloads/git-filter-repo.py --path host --path wasi-common --path test-programs
And then merging wasmtime's
pch/test_programs
@87fedb59d6dcf6081285bf390ccf8b5194eaff2c in with --allow-unrelated-histories.
pchickey updated PR #6391.
jameysharp submitted PR review:
I've glanced over
crates/test-programs
andcrates/wasi/src/preview2
but I assume the idea is we want to merge these as work-in-progress and then iterate on them in-tree, right? I see plenty of fixme-type comments and the like. I was particularly curious about the comment incrates/test-programs/command-tests/src/bin/file_dir_sync.rs
about not being able to open directories as files on Windows.In particular, it looks like the preview2 implementation doesn't interfere at all with using the existing preview1 implementation. If I've missed any caveats to that I'd like to hear about them, but assuming it's true then I think this is fine to merge, since we aren't making any promises about stability of the component model or preview2 yet.
I've reviewed the rest (
supply-chain
,ci/run-tests.sh
, and variousCargo.toml
changes) reasonably carefully.
pchickey updated PR #6391.
pchickey has enabled auto merge for PR #6391.
pchickey updated PR #6391.
pchickey has enabled auto merge for PR #6391.
pchickey updated PR #6391.
pchickey updated PR #6391.
pchickey updated PR #6391.
pchickey updated PR #6391.
pchickey updated PR #6391.
pchickey has enabled auto merge for PR #6391.
pchickey has disabled auto merge for PR #6391.
pchickey updated PR #6391.
pchickey has enabled auto merge for PR #6391.
pchickey merged PR #6391.
Last updated: Dec 23 2024 at 12:05 UTC