Stream: git-wasmtime

Topic: wasmtime / PR #6391 Land preview2-prototyping's Wasi Prev...

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 22:20):

pchickey opened PR #6391 from pchickey:pch/merge_preview2_impl to bytecodealliance:main.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 22:25):

pchickey edited PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 22:26):

pchickey edited PR #6391:

WIP: Currently based on #6385

Third task in #6370

This PR lands preview2-prototyping's Wasi Preview 2 implementation inside wasmtime_wasi::preview2.

python3 ~/Downloads/git-filter-repo.py --path host --path wasi-common --path test-programs

on https://github.com/bytecodealliance/preview2-prototyping/commit/5be99d645c177198b9f5e4d76561669796f7b379

And then merging wasmtime's pch/test_programs@87fedb59d6dcf6081285bf390ccf8b5194eaff2c in with --allow-unrelated-histories.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 23:40):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 00:20):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 03:05):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 03:06):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 17:57):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 19:15):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 17 2023 at 23:12):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 00:26):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 00:27):

pchickey edited PR #6391:

Third task in #6370

This PR lands preview2-prototyping's Wasi Preview 2 implementation inside wasmtime_wasi::preview2.

Needs https://github.com/bytecodealliance/wasmtime/pull/6404 to pass all tests.

python3 ~/Downloads/git-filter-repo.py --path host --path wasi-common --path test-programs

on https://github.com/bytecodealliance/preview2-prototyping/commit/5be99d645c177198b9f5e4d76561669796f7b379

And then merging wasmtime's pch/test_programs@87fedb59d6dcf6081285bf390ccf8b5194eaff2c in with --allow-unrelated-histories.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 16:49):

alexcrichton created PR review comment:

oh man blast from the past

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 17:08):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 17:49):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 17:50):

pchickey has marked PR #6391 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 17:50):

pchickey requested jameysharp for a review on PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 17:50):

pchickey requested wasmtime-core-reviewers for a review on PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 17:50):

pchickey requested wasmtime-default-reviewers for a review on PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 18:01):

pchickey edited PR #6391:

Third task in #6370

This PR lands preview2-prototyping's Wasi Preview 2 implementation inside wasmtime_wasi::preview2.

python3 ~/Downloads/git-filter-repo.py --path host --path wasi-common --path test-programs

on https://github.com/bytecodealliance/preview2-prototyping/commit/5be99d645c177198b9f5e4d76561669796f7b379

And then merging wasmtime's pch/test_programs@87fedb59d6dcf6081285bf390ccf8b5194eaff2c in with --allow-unrelated-histories.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 19:26):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 19:46):

jameysharp submitted PR review:

I've glanced over crates/test-programs and crates/wasi/src/preview2 but I assume the idea is we want to merge these as work-in-progress and then iterate on them in-tree, right? I see plenty of fixme-type comments and the like. I was particularly curious about the comment in crates/test-programs/command-tests/src/bin/file_dir_sync.rs about not being able to open directories as files on Windows.

In particular, it looks like the preview2 implementation doesn't interfere at all with using the existing preview1 implementation. If I've missed any caveats to that I'd like to hear about them, but assuming it's true then I think this is fine to merge, since we aren't making any promises about stability of the component model or preview2 yet.

I've reviewed the rest (supply-chain, ci/run-tests.sh, and various Cargo.toml changes) reasonably carefully.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 21:21):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 21:23):

pchickey has enabled auto merge for PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 21:57):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 21:58):

pchickey has enabled auto merge for PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 22:35):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 22:38):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 22:40):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 22:58):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 18 2023 at 23:37):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 19 2023 at 00:12):

pchickey has enabled auto merge for PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 19 2023 at 00:12):

pchickey has disabled auto merge for PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 19 2023 at 00:21):

pchickey updated PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 19 2023 at 00:21):

pchickey has enabled auto merge for PR #6391.

view this post on Zulip Wasmtime GitHub notifications bot (May 19 2023 at 01:21):

pchickey merged PR #6391.

Last updated: Nov 22 2024 at 17:03 UTC