Wasmtime GitHub notifications bot (May 16 2023 at 21:23): Wasmtime GitHub notifications bot (May 16 2023 at 21:23):alexcrichton opened PR #6390 from alexcrichton:wit-changes to bytecodealliance:main:
This PR integrates bytecodealliance/wasm-tools#1027 into Wasmtime. The main changes here are:
- WIT syntax is updated with WebAssembly/component-model#193
- Generated bindings in the
bindgen!macro have been updated to reflect the new structure of WIT.- The accepted component model binary format has been updated to account for changes.
This PR disables wasi-http tests and the on-by-default feature because the WIT syntax has been updated but the submodule containing the WITs has not been updated yet so there's no way to get that building temporarily. Once that's updated then this can be reenabled.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 16 2023 at 21:27):alexcrichton updated PR #6390.
Wasmtime GitHub notifications bot (May 17 2023 at 14:33):alexcrichton updated PR #6390.
Wasmtime GitHub notifications bot (May 17 2023 at 16:19):alexcrichton updated PR #6390.
Wasmtime GitHub notifications bot (May 17 2023 at 19:01):alexcrichton updated PR #6390.
Wasmtime GitHub notifications bot (May 17 2023 at 19:12):alexcrichton updated PR #6390.
Wasmtime GitHub notifications bot (May 17 2023 at 19:21):alexcrichton updated PR #6390.
Wasmtime GitHub notifications bot (May 25 2023 at 21:05):alexcrichton updated PR #6390.
Wasmtime GitHub notifications bot (May 25 2023 at 21:07):alexcrichton has marked PR #6390 as ready for review.
Wasmtime GitHub notifications bot (May 25 2023 at 21:07):alexcrichton requested elliottt for a review on PR #6390.
Wasmtime GitHub notifications bot (May 25 2023 at 21:07):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6390.
Wasmtime GitHub notifications bot (May 25 2023 at 21:07):alexcrichton requested wasmtime-core-reviewers for a review on PR #6390.
Wasmtime GitHub notifications bot (May 25 2023 at 21:07):alexcrichton requested jameysharp for a review on PR #6390.
Wasmtime GitHub notifications bot (May 25 2023 at 21:07):alexcrichton requested wasmtime-default-reviewers for a review on PR #6390.
Wasmtime GitHub notifications bot (May 25 2023 at 21:10):alexcrichton requested pchickey for a review on PR #6390.
Wasmtime GitHub notifications bot (May 25 2023 at 21:41):alexcrichton updated PR #6390.
Wasmtime GitHub notifications bot (May 25 2023 at 22:42):pchickey submitted PR review.
Wasmtime GitHub notifications bot (May 25 2023 at 22:43):sunfishcode submitted PR review.
Wasmtime GitHub notifications bot (May 25 2023 at 22:43):sunfishcode submitted PR review.
Wasmtime GitHub notifications bot (May 25 2023 at 22:43):sunfishcode created PR review comment:
What is this
main.witfor?
Wasmtime GitHub notifications bot (May 26 2023 at 13:57):alexcrichton created PR review comment:
Without any
*.witfiles the current implementation inwit-parserreturns an error during parsing saying "nopackageheader was found" since it doesn't have a special case for zero parsed files. I can follow-up though with a special case to handle that.
Wasmtime GitHub notifications bot (May 26 2023 at 14:05):alexcrichton updated PR #6390.
Wasmtime GitHub notifications bot (May 26 2023 at 14:16):alexcrichton updated PR #6390.
Wasmtime GitHub notifications bot (May 26 2023 at 14:21):alexcrichton has enabled auto merge for PR #6390.
Wasmtime GitHub notifications bot (May 26 2023 at 14:58):alexcrichton updated PR #6390.
Wasmtime GitHub notifications bot (May 26 2023 at 15:01):alexcrichton has enabled auto merge for PR #6390.
Wasmtime GitHub notifications bot (May 26 2023 at 16:06):alexcrichton updated PR #6390.
Wasmtime GitHub notifications bot (May 26 2023 at 16:07):alexcrichton has enabled auto merge for PR #6390.
Wasmtime GitHub notifications bot (May 26 2023 at 16:16):alexcrichton updated PR #6390.
Wasmtime GitHub notifications bot (May 26 2023 at 17:13):alexcrichton merged PR #6390.
Last updated: Dec 23 2024 at 12:05 UTC