Stream: git-wasmtime

Topic: wasmtime / PR #6389 Fix scheme for URIs, add coverage to ...

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 20:47):

brendandburns opened PR #6389 from brendandburns:fix2 to bytecodealliance:main:

https://github.com/bytecodealliance/wasmtime/pull/6357 broke the scheme formatting by adding an extra :// but the tests didn't have enough coverage to catch it.

Improve the tests, fix the bug.

cc @pchickey @eduardomourar

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 20:47):

brendandburns requested pchickey for a review on PR #6389.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 20:47):

brendandburns requested wasmtime-core-reviewers for a review on PR #6389.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 20:50):

eduardomourar submitted PR review:

Thanks

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 21:36):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 16 2023 at 22:14):

pchickey merged PR #6389.

Last updated: Nov 22 2024 at 16:03 UTC