saulecabrera opened PR #6387 from saulecabrera:winch-add-traps-to-obj
to bytecodealliance:main
:
This change is a follow-up to
https://github.com/bytecodealliance/wasmtime/pull/6298, in which the function traps were not added to the final object.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
saulecabrera requested itsrainy for a review on PR #6387.
saulecabrera requested wasmtime-core-reviewers for a review on PR #6387.
alexcrichton submitted PR review:
Looks good to me!
FWIW this is something that I think would be good to deduplicate between Cranelift and Winch since, in the end, the compiled function representation is more-or-less the same ("it's just a
MachBufferFinalized
") so it should be able to share this. Ideally the winch/Cranelift split would purely be "give me a compiled function a different way" to help share more code. In any case though that's for future refactorings, no need to block this of course.
alexcrichton has enabled auto merge for PR #6387.
alexcrichton merged PR #6387.
Last updated: Dec 23 2024 at 12:05 UTC