fitzgen requested wasmtime-core-reviewers for a review on PR #6381.
fitzgen opened PR #6381 from fitzgen:refactor-parallel-compilation
to bytecodealliance:main
:
Before, the acts of discovering what we need to compile and actually compiling those things was intertwined. This meant that we weren't fanning out as wide as we could in parallel compilation because we would do things like compile all Wasm functions in parallel, and all wasm-to-native trampolines in parallel, but not compile those two groups in parallel with each other.
Now we split discovery and compilation into separate phases: first we discover all the work we need to do, then we do it all in parallel at once.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
fitzgen requested alexcrichton for a review on PR #6381.
alexcrichton created PR review comment:
I'm a bit scared that at some point during development an i132 was used
alexcrichton submitted PR review:
Nice! I really like how this turned out :+1:
alexcrichton submitted PR review:
Nice! I really like how this turned out :+1:
alexcrichton created PR review comment:
These
symbol_name
functions may be best to move here now since they should only be called from this location?
alexcrichton created PR review comment:
No changes necessary, but I've found that
[expr]
works nowadays for "iterate this thing once" which I think reads pretty well too
alexcrichton created PR review comment:
This'll want a gate that there's only one translation because otherwise appending dwarf multiple times will end up with something corrupt that nothing can read
alexcrichton created PR review comment:
Perhaps assert that
self.indices
is empty just above this?
fitzgen created PR review comment:
Oh nice, I always forget that arrays are useful now.
fitzgen created PR review comment:
Maybe? I kind of like them as methods on the thing.
fitzgen updated PR #6381.
fitzgen has enabled auto merge for PR #6381.
fitzgen merged PR #6381.
Last updated: Dec 23 2024 at 12:05 UTC