Wasmtime GitHub notifications bot (May 15 2023 at 17:31): Wasmtime GitHub notifications bot (May 15 2023 at 17:31):elliottt opened PR #6377 from elliottt:trevor/revert-lea to bytecodealliance:main:
This caused a performance regression on some inputs, so we're going to revert for now and investigate other paths for implementing this optimization.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 15 2023 at 17:31):elliottt requested jameysharp for a review on PR #6377.
Wasmtime GitHub notifications bot (May 15 2023 at 17:31):elliottt requested wasmtime-compiler-reviewers for a review on PR #6377.
Wasmtime GitHub notifications bot (May 15 2023 at 17:31):elliottt requested alexcrichton for a review on PR #6377.
Wasmtime GitHub notifications bot (May 15 2023 at 17:31):elliottt edited PR #6377:
The lea-based lowering for iadd on x64 (#5986) caused a performance regression on some inputs, so we're going to revert for now and investigate other paths for implementing this optimization.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 15 2023 at 17:32):elliottt edited PR #6377:
The lea-based lowering for iadd on x64 (#5986) caused a compilation performance regression on some inputs, so we're going to revert for now and investigate other paths for implementing this optimization.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 15 2023 at 17:35):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (May 15 2023 at 18:58):elliottt merged PR #6377.
Last updated: Nov 22 2024 at 16:03 UTC