Stream: git-wasmtime

Topic: wasmtime / PR #6374 Land preview2-prototying's wasi-previ...

view this post on Zulip Wasmtime GitHub notifications bot (May 12 2023 at 18:06):

pchickey opened PR #6374 from pchickey:pch/merge_adapter_to_wasmtime to bytecodealliance:main:

First task in #6370

This introduces preview2-prototyping's wasi-preview1-component-adapter into wasmtime's crates/. The git history has been preserved.

TODO: add build, test, and publish to CI

How this PR was made

I made this branch by running

$ python3 ~/Downloads/git-filter-repo.py --path crates --path src --path build.rs --force

on https://github.com/bytecodealliance/preview2-prototyping/commit/5be99d645c177198b9f5e4d76561669796f7b379

And then merging wasmtime's main in with --allow-unrelated-histories.

view this post on Zulip Wasmtime GitHub notifications bot (May 12 2023 at 20:55):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 12 2023 at 21:09):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 12 2023 at 21:16):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 12 2023 at 21:25):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 12 2023 at 21:27):

pchickey edited PR #6374:

First task in #6370

This introduces preview2-prototyping's wasi-preview1-component-adapter into wasmtime's crates/. The git history has been preserved.

There is a new script ./ci/build-wasi-preview1-component-adapter.sh to build and verify the adapter, and a a new CI check which runs this script and uploads the release builds as artifacts.

How this PR was made

I made this branch by running

$ python3 ~/Downloads/git-filter-repo.py --path crates --path src --path build.rs --force

on https://github.com/bytecodealliance/preview2-prototyping/commit/5be99d645c177198b9f5e4d76561669796f7b379

And then merging wasmtime's main in with --allow-unrelated-histories.

view this post on Zulip Wasmtime GitHub notifications bot (May 12 2023 at 21:28):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 12 2023 at 21:49):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 12 2023 at 22:23):

pchickey has marked PR #6374 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (May 12 2023 at 22:23):

pchickey requested fitzgen for a review on PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 12 2023 at 22:23):

pchickey requested wasmtime-core-reviewers for a review on PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 12 2023 at 22:23):

pchickey requested wasmtime-default-reviewers for a review on PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 12 2023 at 22:31):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 14 2023 at 00:39):

alexcrichton submitted PR review:

Looks good to me, but I'd ideally like to get the workspace stuff sorted out before landing if that's ok. If this is holding up too much else though and that's not easy to get working I can work on it later and you can go ahead and land this.

view this post on Zulip Wasmtime GitHub notifications bot (May 14 2023 at 00:39):

alexcrichton submitted PR review:

Looks good to me, but I'd ideally like to get the workspace stuff sorted out before landing if that's ok. If this is holding up too much else though and that's not easy to get working I can work on it later and you can go ahead and land this.

view this post on Zulip Wasmtime GitHub notifications bot (May 14 2023 at 00:39):

alexcrichton created PR review comment:

Could this file get removed?

view this post on Zulip Wasmtime GitHub notifications bot (May 14 2023 at 00:39):

alexcrichton created PR review comment:

Could this be left out until CI is added to verify it's right?

view this post on Zulip Wasmtime GitHub notifications bot (May 14 2023 at 00:39):

alexcrichton created PR review comment:

Could this get removed so this is integrated into the main wasmtime workspace? I think the above fiddly bits about profiles and such can go into the main workspace as well and apply to just this one crate.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 03:10):

pchickey created PR review comment:

Yes, this should be left out until we actually setup wit-deps to point at the standards repos and check things properly in CI.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 03:10):

pchickey created PR review comment:

Yes if we fix the workspace.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 03:10):

pchickey created PR review comment:

I would love to put it all in one workspace, yeah. I wasn't able to figure out how to apply these profiles to just one crate, but if we can do it then

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 03:11):

pchickey edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 16:29):

alexcrichton created PR review comment:

I think profile overrides show enable that?

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 16:35):

pchickey created PR review comment:

That didn't work because

Overrides cannot specify the panic ... settings
but I just realized, since that we have to avoid the panic machinery for vtable reasons, maybe the adapter will also build correctly without that in the profile...

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 16:36):

pchickey edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 16:41):

alexcrichton created PR review comment:

oh that should also be ok because wasm doesn't actually support panic=unwind vs panic=abort, it's just always panic=abort anyway. So that setting can be dropped without affecting the output.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 17:00):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 17:00):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 17:01):

pchickey created PR review comment:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 18:12):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 18:15):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 18:22):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 18:28):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 19:27):

alexcrichton created PR review comment:

Instead of this could the manifest of the adapter say test = false for the [lib] section?

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 19:57):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 20:41):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 21:11):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 21:19):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 21:28):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 22:45):

pchickey updated PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 22:52):

pchickey has enabled auto merge for PR #6374.

view this post on Zulip Wasmtime GitHub notifications bot (May 15 2023 at 23:36):

pchickey merged PR #6374.

Last updated: Dec 23 2024 at 13:07 UTC