Wasmtime GitHub notifications bot (May 11 2023 at 16:56): Wasmtime GitHub notifications bot (May 11 2023 at 16:56):alexcrichton opened PR #6372 from alexcrichton:x64-sse2-sshr to bytecodealliance:main:
The previous implementation fell back to a scalar implementation by extracting lanes and re-inserting them. These operations are significantly more complicated without SSE 4.1, however. Comparing against LLVM's lowerings, as well, it looks like a different strategy is used which avoids extracting and inserting lanes. This commit updates to follow the strategy matched by LLVM's lowerings which additionally has the benefit of providing a non-SSE4.1 implementation.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 11 2023 at 16:56):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6372.
Wasmtime GitHub notifications bot (May 11 2023 at 16:56):alexcrichton requested fitzgen for a review on PR #6372.
Wasmtime GitHub notifications bot (May 11 2023 at 16:56):alexcrichton requested abrown for a review on PR #6372.
Wasmtime GitHub notifications bot (May 11 2023 at 16:56):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6372.
Wasmtime GitHub notifications bot (May 17 2023 at 15:10):abrown submitted PR review.
Wasmtime GitHub notifications bot (May 17 2023 at 15:10):abrown created PR review comment:
I guess since we're here we could remove this comment: "but this backend does not currently have support for EVEX encodings." That is no longer true and
vpsraqis an instruction lowering that could be added eventually (an opposite direction from this PR which is adding lowerings for older features).
Wasmtime GitHub notifications bot (May 17 2023 at 15:10):abrown submitted PR review.
Wasmtime GitHub notifications bot (May 17 2023 at 16:26):alexcrichton updated PR #6372.
Wasmtime GitHub notifications bot (May 17 2023 at 16:26):alexcrichton has enabled auto merge for PR #6372.
Wasmtime GitHub notifications bot (May 17 2023 at 17:27):alexcrichton merged PR #6372.
Last updated: Oct 23 2024 at 20:03 UTC