Wasmtime GitHub notifications bot (May 10 2023 at 08:20): Wasmtime GitHub notifications bot (May 10 2023 at 08:20):loganek opened PR #6365 from loganek:main to bytecodealliance:main:
Instead of passing environment variables from the spec file to the sandboxed environment, we set them for the execution environment of the process (therefore they were not available for WASM test application).
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 10 2023 at 08:20):loganek requested alexcrichton for a review on PR #6365.
Wasmtime GitHub notifications bot (May 10 2023 at 08:20):loganek requested wasmtime-core-reviewers for a review on PR #6365.
Wasmtime GitHub notifications bot (May 10 2023 at 08:23):loganek updated PR #6365.
Wasmtime GitHub notifications bot (May 10 2023 at 13:42):abrown submitted PR review.
Wasmtime GitHub notifications bot (May 10 2023 at 15:33):alexcrichton merged PR #6365.
Last updated: Oct 23 2024 at 20:03 UTC