Stream: git-wasmtime

Topic: wasmtime / PR #6362 Fold guest profiling flags into `--pr...

Wasmtime GitHub notifications bot (May 09 2023 at 16:57):

alexcrichton opened PR #6362 from alexcrichton:consolidate-profile to bytecodealliance:main:

This commit removes the --profile-guest and --profile-guest-interval CLI flags and folds them into the preexisting --profile flag. Specifying guest profiling can now be done with --profile guest which has a default path/interval to write to. The path/interval can be configured with --profile guest,path.json and --profile guest,path.json,10ms.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 09 2023 at 16:57):

alexcrichton requested fitzgen for a review on PR #6362.

Wasmtime GitHub notifications bot (May 09 2023 at 16:57):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6362.

Wasmtime GitHub notifications bot (May 09 2023 at 17:34):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (May 09 2023 at 17:34):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (May 09 2023 at 17:34):

fitzgen created PR review comment:

                // Further configured down below as well.

Wasmtime GitHub notifications bot (May 09 2023 at 17:34):

fitzgen created PR review comment:

Care to (in a follow up) rename wasmtime::ProfilingStrategy to wasmtime::NativeProfilingStrategy and have

#[deprecated("Renamed to NativeProfilingStrategy")]
pub type ProfilingStrategy = NativeProfilingStrategy;

for backwards compatibility?

Wasmtime GitHub notifications bot (May 09 2023 at 19:23):

alexcrichton updated PR #6362.

Wasmtime GitHub notifications bot (May 09 2023 at 19:23):

alexcrichton created PR review comment:

Sure!

Wasmtime GitHub notifications bot (May 09 2023 at 19:23):

alexcrichton has enabled auto merge for PR #6362.

Wasmtime GitHub notifications bot (May 09 2023 at 20:09):

alexcrichton merged PR #6362.

Last updated: Nov 22 2024 at 17:03 UTC