Wasmtime GitHub notifications bot (May 09 2023 at 16:35): Wasmtime GitHub notifications bot (May 09 2023 at 16:35):alexcrichton opened PR #6361 from alexcrichton:refactor-profiling to bytecodealliance:main:
This commit refactors the profiling support for existing agents in Wasmtime. The end goal was to handle #6328 and I ended up doing a fair bit of other cleanup along the way. The profilers are now all centered around "load a single function" rather than dealing with both modules and trampolines. The shared logic of parsing an ELF file is located in one place now in shared support across all profilers.
This also applies refactorings such as removing DWARF support for jitdump which while not problematic hasn't been necessary for me historically. Additionally Wasmtime's support for DWARF is too buggy to enable so it's not getting any use anyway.
Wasmtime GitHub notifications bot (May 09 2023 at 16:35):alexcrichton requested itsrainy for a review on PR #6361.
Wasmtime GitHub notifications bot (May 09 2023 at 16:35):alexcrichton requested wasmtime-core-reviewers for a review on PR #6361.
Wasmtime GitHub notifications bot (May 09 2023 at 16:35):alexcrichton requested wasmtime-default-reviewers for a review on PR #6361.
Wasmtime GitHub notifications bot (May 09 2023 at 16:58):alexcrichton updated PR #6361.
Wasmtime GitHub notifications bot (May 09 2023 at 18:11):fitzgen submitted PR review:
Very nice!
Wasmtime GitHub notifications bot (May 09 2023 at 18:12):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (May 09 2023 at 19:20):alexcrichton updated PR #6361.
Wasmtime GitHub notifications bot (May 09 2023 at 19:20):alexcrichton has enabled auto merge for PR #6361.
Wasmtime GitHub notifications bot (May 09 2023 at 20:07):alexcrichton merged PR #6361.
Last updated: Oct 23 2024 at 20:03 UTC