Stream: git-wasmtime

Topic: wasmtime / PR #6360 Make libcalls slightly safer

Wasmtime GitHub notifications bot (May 09 2023 at 15:12):

alexcrichton opened PR #6360 from alexcrichton:libcalls-lightly-more-safe to bytecodealliance:main:

Bake in the *mut VMContext to &mut Instance translation into the macro-generated trampolines to avoid the need to use Instance::from_vmctx with an extra level of indentation everywhere. Additionally some libcalls are now entirely safe code as their one unsafe operation was the VMContext to Instance translation.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 09 2023 at 15:12):

alexcrichton requested pchickey for a review on PR #6360.

Wasmtime GitHub notifications bot (May 09 2023 at 15:12):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6360.

Wasmtime GitHub notifications bot (May 09 2023 at 15:21):

pchickey submitted PR review:

Nice

Wasmtime GitHub notifications bot (May 09 2023 at 15:22):

alexcrichton has enabled auto merge for PR #6360.

Wasmtime GitHub notifications bot (May 09 2023 at 16:11):

alexcrichton merged PR #6360.

Last updated: Nov 22 2024 at 17:03 UTC