Stream: git-wasmtime

Topic: wasmtime / PR #6354 x64: Add non-SSE4.1 lowerings for `ex...

Wasmtime GitHub notifications bot (May 08 2023 at 19:51):

alexcrichton opened PR #6354 from alexcrichton:x64-sse2-extractlane to bytecodealliance:main:

This affects some specializations of extract-to-memory which involved adding guards, and for the general cases involved adding specialized lowerings that don't use the pextr* instructions.

Additionally this also removes the optimization where an extend-to-larger-width operation was removed after an extractlane since now the lowerings for extractlane may conditionally auto-zero-extend and may not. To avoid any subtle future bugs here the optimization is removed, and if needed in the future it's hoped by that point it's either easier to add back in or it's more clear why the maintenance burden should be required.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 08 2023 at 19:51):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6354.

Wasmtime GitHub notifications bot (May 08 2023 at 19:51):

alexcrichton requested abrown for a review on PR #6354.

Wasmtime GitHub notifications bot (May 11 2023 at 00:42):

abrown submitted PR review:

LGTM!

Wasmtime GitHub notifications bot (May 11 2023 at 00:42):

abrown submitted PR review:

LGTM!

Wasmtime GitHub notifications bot (May 11 2023 at 00:42):

abrown created PR review comment:

Maybe we don't need to document this everywhere but whenever I see this kind of thing I have to remind myself that the type system never lets us see the other bits. It's up to you if it is helpful to remind future readers of that.

Wasmtime GitHub notifications bot (May 11 2023 at 15:24):

alexcrichton updated PR #6354.

Wasmtime GitHub notifications bot (May 11 2023 at 15:24):

alexcrichton has enabled auto merge for PR #6354.

Wasmtime GitHub notifications bot (May 11 2023 at 16:34):

alexcrichton merged PR #6354.

Last updated: Nov 22 2024 at 17:03 UTC