Stream: git-wasmtime

Topic: wasmtime / PR #6344 Cranelift: Fix panic when pretty prin...

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2023 at 23:50):

T0b1-iOS opened PR #6344 from T0b1-iOS:fix-emit-pretty-print to bytecodealliance:main:

Fixes #6333

It seems that when the next_fixed_nonallocatable function was added to check if the register allocator allocates these correctly, the check for the case that no allocation is present (e.g. in case the instructions are pretty printed when tracing is enabled) was missed. It is present in the getters below.

I added a check for that and now the tests don't panic anymore when tracing is enabled.

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2023 at 23:50):

T0b1-iOS requested abrown for a review on PR #6344.

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2023 at 23:50):

T0b1-iOS requested wasmtime-compiler-reviewers for a review on PR #6344.

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2023 at 23:58):

cfallin submitted PR review:

Yep, this makes sense; thanks for catching this!

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2023 at 23:59):

cfallin has enabled auto merge for PR #6344.

view this post on Zulip Wasmtime GitHub notifications bot (May 05 2023 at 00:46):

cfallin merged PR #6344.

Last updated: Dec 23 2024 at 13:07 UTC