Wasmtime GitHub notifications bot (May 04 2023 at 21:28): Wasmtime GitHub notifications bot (May 04 2023 at 21:28):abrown opened PR #6343 from abrown:fix-some-wasi-tests to bytecodealliance:main:
After thinking about this some more, I took another look at fixing some issues with the test cases. By doing the following, many more test cases now pass:
- this change cleans up garbage files created by the test
- this change also fixes how directories are mapped, using
--mapdirinstead of--dir
See the commit messages for more detail.
Wasmtime GitHub notifications bot (May 04 2023 at 21:28):abrown requested fitzgen for a review on PR #6343.
Wasmtime GitHub notifications bot (May 04 2023 at 21:28):abrown requested wasmtime-core-reviewers for a review on PR #6343.
Wasmtime GitHub notifications bot (May 04 2023 at 21:29):abrown edited PR #6343:
After thinking about this some more, I took another look at fixing some issues with the test cases. By doing the following, many more test cases now pass:
- this change cleans up garbage files created by the test
- this change also fixes how directories are mapped, using
--mapdirinstead of--dirSee the commit messages for more detail.
Wasmtime GitHub notifications bot (May 04 2023 at 21:36):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (May 04 2023 at 21:36):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (May 04 2023 at 21:36):alexcrichton created PR review comment:
Instead of passing the raw directory in the spec test suite to each test, could the directory perhaps be copied to a temporary location and have the test run against that? That way the temporary directory clean up would removing any extra files and the
clean_garbagefiltering may not be necessary?Alternatively though explicitly cleaning out files I think is ok, and if this is how the test suite runs upstream I think it's fine to mirror that as well.
Wasmtime GitHub notifications bot (May 04 2023 at 21:51):abrown created PR review comment:
Well, right now I believe the other
wasi-testsuitetest runner (the Python one) expects to clean up any*.cleanupfiles so I propose we stick with that for now. I opened https://github.com/WebAssembly/wasi-testsuite/pull/74 to actually right down what a test runner should do and I added a comment there about this. How about we change this logic once we decide what to do there?
Wasmtime GitHub notifications bot (May 04 2023 at 21:51):abrown edited PR review comment.
Wasmtime GitHub notifications bot (May 04 2023 at 23:33):alexcrichton created PR review comment:
Sounds good to me :+1:
Wasmtime GitHub notifications bot (May 05 2023 at 01:41):abrown merged PR #6343.
Last updated: Nov 22 2024 at 17:03 UTC