Wasmtime GitHub notifications bot (May 04 2023 at 16:26): Wasmtime GitHub notifications bot (May 04 2023 at 16:26):alexcrichton opened PR #6340 from alexcrichton:fix-differential-fuzz to bytecodealliance:main:
Execution of functions handles the case where one instance stack overflows and the other didn't, but instantiation didn't handle this case. This commit fixes this issue by sharing the result comparison logic between the two branches.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 04 2023 at 16:26):alexcrichton requested fitzgen for a review on PR #6340.
Wasmtime GitHub notifications bot (May 04 2023 at 16:26):alexcrichton requested wasmtime-fuzz-reviewers for a review on PR #6340.
Wasmtime GitHub notifications bot (May 04 2023 at 16:26):alexcrichton requested wasmtime-core-reviewers for a review on PR #6340.
Wasmtime GitHub notifications bot (May 04 2023 at 19:30):abrown submitted PR review.
Wasmtime GitHub notifications bot (May 04 2023 at 19:55):bjorn3 created PR review comment:
/// results can no longer be compared.
Wasmtime GitHub notifications bot (May 04 2023 at 19:55):alexcrichton updated PR #6340.
Wasmtime GitHub notifications bot (May 04 2023 at 19:56):alexcrichton has enabled auto merge for PR #6340.
Wasmtime GitHub notifications bot (May 04 2023 at 20:51):alexcrichton merged PR #6340.
Last updated: Oct 23 2024 at 20:03 UTC