Stream: git-wasmtime

Topic: wasmtime / PR #6337 wasmtime: Stop using `cfg(compiler)`

Wasmtime GitHub notifications bot (May 03 2023 at 21:05):

fitzgen opened PR #6337 from fitzgen:no-more-cfg-compiler to bytecodealliance:main:

It was an alias, defined in build.rs, for

cfg(any(feature = "cranelift", feature = "winch"))

But it wasn't actually saving us much typing because we also have to have

#[cfg_attr(nightlydoc, doc(cfg(any(feature = "cranelift", feature = "winch"))))]

for all the public APIs that are gated on a compiler being present so that the API docs show which methods require which features.

So I'm removing it and using the full cfg(any(..)) form instead.

This allows us to remove a build.rs that is otherwise unused and helps rust-analyzer give better code completions and jump-to-definitions and things.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 03 2023 at 21:05):

fitzgen requested alexcrichton for a review on PR #6337.

Wasmtime GitHub notifications bot (May 03 2023 at 21:05):

fitzgen requested wasmtime-core-reviewers for a review on PR #6337.

Wasmtime GitHub notifications bot (May 03 2023 at 21:06):

fitzgen updated PR #6337.

Wasmtime GitHub notifications bot (May 03 2023 at 21:34):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (May 09 2023 at 19:22):

fitzgen updated PR #6337.

Wasmtime GitHub notifications bot (May 09 2023 at 19:22):

fitzgen has enabled auto merge for PR #6337.

Wasmtime GitHub notifications bot (May 09 2023 at 20:17):

fitzgen updated PR #6337.

Wasmtime GitHub notifications bot (May 09 2023 at 20:18):

fitzgen has enabled auto merge for PR #6337.

Wasmtime GitHub notifications bot (May 09 2023 at 21:09):

fitzgen merged PR #6337.

Last updated: Oct 23 2024 at 20:03 UTC