Wasmtime GitHub notifications bot (May 03 2023 at 00:33): Wasmtime GitHub notifications bot (May 03 2023 at 00:33):elliottt opened PR #6334 from elliottt:trevor/fix-table-addr-printing to bytecodealliance:main:
Make table_addr parsing more consistent with other uses of
optional_offset32by not requiring a comma between the index and the offset. Additionally, change the parser to print out the offset.I added a parser test to ensure that the round-tripping is working as expected, and updated existing tests to expect the new printed format.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 03 2023 at 00:33):elliottt requested cfallin for a review on PR #6334.
Wasmtime GitHub notifications bot (May 03 2023 at 00:33):elliottt requested wasmtime-compiler-reviewers for a review on PR #6334.
Wasmtime GitHub notifications bot (May 03 2023 at 04:40):elliottt edited PR #6334:
Make
table_addrparsing more consistent with other uses ofoptional_offset32by not requiring a comma between the index and the offset. Additionally, change the printer to print out the offset.I added a parser test to ensure that the round-tripping is working as expected, and updated existing tests to expect the new printed format.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 03 2023 at 18:36):cfallin submitted PR review:
Thanks, LGTM!
Wasmtime GitHub notifications bot (May 03 2023 at 19:47):cfallin merged PR #6334.
Last updated: Dec 23 2024 at 12:05 UTC