Stream: git-wasmtime

Topic: wasmtime / PR #6318 Split out platform-specific logic for...

Wasmtime GitHub notifications bot (May 01 2023 at 17:23):

alexcrichton opened PR #6318 from alexcrichton:refactor-mmap to bytecodealliance:main:

This commit refactors the implementation of the wasmtime_runtime::Mmap structure to have the platform-specific bits separated by file rather than interspersed throughout mmap.rs. I plan in the near future to add a faux implementation for cfg(miri) to get some tests running with miri on CI.

At the same time this additionally updates the interface of Mmap to be more miri-friendly in the sense of ensuring that mutability is all in the right place and we don't eagerly mark items as safe too soon. For example it seems questionable that previously you could get a mutable slice to readonly memory. Probably not going to cause any issues, but this interface should hopefully be more verification-friendly.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 01 2023 at 17:23):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6318.

Wasmtime GitHub notifications bot (May 01 2023 at 17:23):

alexcrichton requested fitzgen for a review on PR #6318.

Wasmtime GitHub notifications bot (May 01 2023 at 18:12):

fitzgen submitted PR review:

Nice!

Wasmtime GitHub notifications bot (May 02 2023 at 00:25):

alexcrichton updated PR #6318.

Wasmtime GitHub notifications bot (May 02 2023 at 00:25):

alexcrichton has enabled auto merge for PR #6318.

Wasmtime GitHub notifications bot (May 02 2023 at 01:18):

alexcrichton merged PR #6318.

Last updated: Dec 23 2024 at 13:07 UTC