Stream: git-wasmtime

Topic: wasmtime / PR #6317 riscv64: Fix select.i64+icmp.i128 low...

view this post on Zulip Wasmtime GitHub notifications bot (May 01 2023 at 16:51):

afonso360 opened PR #6317 from afonso360:riscv64-fix-select-icmp to bytecodealliance:main:

:wave: Hey,

This fixes #6312. We were accidentally selecting an optimized lowering when the icmp was i128bit. gen_select_reg lowers the comparison, but only looking at the bottom registers since it works with Reg's and not ValueRegs.

I think this bug was also in part introduced by a rule that we have (in the RISC-V backend) that auto converts ValueRegs into Reg silently.

view this post on Zulip Wasmtime GitHub notifications bot (May 01 2023 at 16:51):

afonso360 requested cfallin for a review on PR #6317.

view this post on Zulip Wasmtime GitHub notifications bot (May 01 2023 at 16:51):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #6317.

view this post on Zulip Wasmtime GitHub notifications bot (May 01 2023 at 17:18):

cfallin submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (May 01 2023 at 17:18):

cfallin has enabled auto merge for PR #6317.

view this post on Zulip Wasmtime GitHub notifications bot (May 01 2023 at 17:18):

jameysharp submitted PR review:

This looks exactly right, thank you!

view this post on Zulip Wasmtime GitHub notifications bot (May 01 2023 at 18:10):

cfallin merged PR #6317.

Last updated: Dec 23 2024 at 12:05 UTC