Wasmtime GitHub notifications bot (Apr 27 2023 at 17:37): Wasmtime GitHub notifications bot (Apr 27 2023 at 17:37):alexcrichton opened PR #6295 from alexcrichton:fix-release-versions to bytecodealliance:main:
Since the latest updates to our release process which transitioned to merge queues it appears that patch release create incorrectly named tarballs. The version in the tarball is based on the branch name, which doesn't change for patch releases, so the version needs to come from
Cargo.toml. Thankfully there's already a helpful shell script to do that so use the shell script instead of using the branch name.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 27 2023 at 17:37):alexcrichton requested cfallin for a review on PR #6295.
Wasmtime GitHub notifications bot (Apr 27 2023 at 17:37):alexcrichton requested wasmtime-default-reviewers for a review on PR #6295.
Wasmtime GitHub notifications bot (Apr 27 2023 at 17:40):jameysharp submitted PR review:
Makes sense to me!
Wasmtime GitHub notifications bot (Apr 27 2023 at 17:41):alexcrichton has enabled auto merge for PR #6295.
Wasmtime GitHub notifications bot (Apr 27 2023 at 18:45):alexcrichton merged PR #6295.
Last updated: Dec 23 2024 at 13:07 UTC