Wasmtime GitHub notifications bot (Apr 27 2023 at 15:04): Wasmtime GitHub notifications bot (Apr 27 2023 at 15:04):martindevans opened PR #6292 from martindevans:wasm_relaxed_simd_capi to bytecodealliance:main:
This allows the new relaxed SIMD features (introduced in https://github.com/bytecodealliance/wasmtime/pull/5892) to be configured through the C API:
Added:
- wasmtime_config_wasm_relaxed_simd_set(bool)
- wasmtime_config_wasm_relaxed_simd_deterministic_set(bool)
Wasmtime GitHub notifications bot (Apr 27 2023 at 15:04):martindevans requested pchickey for a review on PR #6292.
Wasmtime GitHub notifications bot (Apr 27 2023 at 15:04):martindevans requested wasmtime-core-reviewers for a review on PR #6292.
Wasmtime GitHub notifications bot (Apr 27 2023 at 15:14):martindevans updated PR #6292.
Wasmtime GitHub notifications bot (Apr 27 2023 at 15:43):alexcrichton submitted PR review:
Thanks! Can you also add C header API definitions for these new functions?
Wasmtime GitHub notifications bot (Apr 27 2023 at 15:43):alexcrichton submitted PR review:
Thanks! Can you also add C header API definitions for these new functions?
Wasmtime GitHub notifications bot (Apr 27 2023 at 15:43):alexcrichton created PR review comment:
I think that this link reference may need to stay?
Wasmtime GitHub notifications bot (Apr 27 2023 at 19:39):martindevans created PR review comment:
Since there's now a separate method (
wasm_relaxed_simd) which is specific to relaxed SIMD and references that proposal I thought it was best to remove it from here and leave it referenced in the more specific place. I can add it back in if you'd prefer though?
Wasmtime GitHub notifications bot (Apr 27 2023 at 19:39):martindevans updated PR #6292.
Wasmtime GitHub notifications bot (Apr 27 2023 at 20:48):alexcrichton created PR review comment:
Oh that's fine, but the above text still has
[relaxed simd proposal]which should either have the[..]removed or this should stay to keep that linked (or it should link somewhere else)
Wasmtime GitHub notifications bot (Apr 27 2023 at 20:53):martindevans created PR review comment:
Ah I see, I didn't realise they were acting as references for the above links! I've added it back in.
Wasmtime GitHub notifications bot (Apr 27 2023 at 20:53):martindevans updated PR #6292.
Wasmtime GitHub notifications bot (Apr 27 2023 at 21:09):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Apr 27 2023 at 21:10):alexcrichton has enabled auto merge for PR #6292.
Wasmtime GitHub notifications bot (Apr 27 2023 at 22:01):alexcrichton merged PR #6292.
Last updated: Oct 23 2024 at 20:03 UTC