Wasmtime GitHub notifications bot (Apr 27 2023 at 03:27): Wasmtime GitHub notifications bot (Apr 27 2023 at 03:27):alexcrichton opened PR #6291 from alexcrichton:x64-icmp-simd-lowerings to bytecodealliance:main:
This commit updates the x64 backend to avoid using various
p{min,max}*instructions if SSE 4.1 isn't enabled. These instructions are used for comparisons as well as the{u,s}{min,max}instructions. Alternative lowerings are primarily drawn from LLVM.Through this refactoring the x64 backend now has also grown (not the most efficient) lowerings for vector comparisons with
i64x2types, which it previously largely didn't have. This enabled copying some non-x86_64 tests into the main test files for various operations.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 27 2023 at 03:27):alexcrichton requested abrown for a review on PR #6291.
Wasmtime GitHub notifications bot (Apr 27 2023 at 03:27):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6291.
Wasmtime GitHub notifications bot (May 01 2023 at 21:13):abrown submitted PR review.
Wasmtime GitHub notifications bot (May 01 2023 at 21:13):abrown submitted PR review.
Wasmtime GitHub notifications bot (May 01 2023 at 21:13):abrown created PR review comment:
We can probably remove this TODO I added long ago? I think the issue it refers to is now closed.
Wasmtime GitHub notifications bot (May 01 2023 at 21:13):abrown created PR review comment:
(mask Xmm (flip_high_bit_mask ty))
Wasmtime GitHub notifications bot (May 01 2023 at 23:55):alexcrichton updated PR #6291.
Wasmtime GitHub notifications bot (May 01 2023 at 23:55):alexcrichton has enabled auto merge for PR #6291.
Wasmtime GitHub notifications bot (May 02 2023 at 01:12):alexcrichton merged PR #6291.
Last updated: Oct 23 2024 at 20:03 UTC