Stream: git-wasmtime

Topic: wasmtime / PR #6289 cranelift: Add missing control plane ...

Wasmtime GitHub notifications bot (Apr 26 2023 at 15:20):

saulecabrera opened PR #6289 from saulecabrera:fix-inc-cache-compilation to bytecodealliance:main:

It seems that this fell through given that the incremental cache is behind a cargo feature. I noticed this while building cranelift-codegen via cargo build --all-features.

I opted to add a check in CI to hopefully prevent this in the future, but I'm happy to remove it / update it if there's a better way or another way.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 26 2023 at 15:20):

saulecabrera requested jameysharp for a review on PR #6289.

Wasmtime GitHub notifications bot (Apr 26 2023 at 15:20):

saulecabrera requested wasmtime-default-reviewers for a review on PR #6289.

Wasmtime GitHub notifications bot (Apr 26 2023 at 15:20):

saulecabrera requested wasmtime-core-reviewers for a review on PR #6289.

Wasmtime GitHub notifications bot (Apr 26 2023 at 15:20):

saulecabrera edited PR #6289:

It seems that this fell through given that the incremental cache is behind a cargo feature. I noticed this while building cranelift-codegen via cargo build --all-features.

I opted to add a check in CI to hopefully prevent this in the future, but I'm happy to remove it / update it if there's a better way or another way.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 26 2023 at 15:21):

saulecabrera updated PR #6289.

Wasmtime GitHub notifications bot (Apr 26 2023 at 15:24):

cfallin submitted PR review:

Thanks; and thanks for adding the cargo check to CI -- we should have had that in the first place!

Wasmtime GitHub notifications bot (Apr 26 2023 at 15:24):

cfallin has enabled auto merge for PR #6289.

Wasmtime GitHub notifications bot (Apr 26 2023 at 16:15):

cfallin merged PR #6289.

Last updated: Dec 23 2024 at 12:05 UTC