Stream: git-wasmtime

Topic: wasmtime / PR #6280 wasmtime-runtime: Re-export backtrace...

Wasmtime GitHub notifications bot (Apr 24 2023 at 20:43):

jameysharp opened PR #6280 from jameysharp:runtime-pub-frame to bytecodealliance:main:

This crate re-exports the Backtrace type at top-level from a nested module. Backtrace in turn has Frame in its public API, which is not re-exported anywhere. This is legal and external users can call methods on Frame, but it doesn't appear in the rustdocs, making it unnecessarily difficult to figure out how to use this API. Re-exporting Frame fixes that, and also allows naming the type directly if needed.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 24 2023 at 20:43):

jameysharp requested pchickey for a review on PR #6280.

Wasmtime GitHub notifications bot (Apr 24 2023 at 20:43):

jameysharp requested wasmtime-core-reviewers for a review on PR #6280.

Wasmtime GitHub notifications bot (Apr 24 2023 at 20:51):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Apr 25 2023 at 01:41):

jameysharp merged PR #6280.

Last updated: Dec 23 2024 at 13:07 UTC