Stream: git-wasmtime

Topic: wasmtime / PR #6278 wasmtime: remove `drop(&mut ...)` use...

Wasmtime GitHub notifications bot (Apr 24 2023 at 18:47):

jameysharp opened PR #6278 from jameysharp:no-magic-drop to bytecodealliance:main:

The Config needs to be mutable while building a compiler, but in a build configuration without a compiler, declaring it as mut produces a warning since nothing else needs that.

I found the existing workaround for this warning confusing, so this PR removes mut from the binding for config and instead re-binds the variable in builds where we call build_compiler.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 24 2023 at 18:47):

jameysharp requested fitzgen for a review on PR #6278.

Wasmtime GitHub notifications bot (Apr 24 2023 at 18:47):

jameysharp requested wasmtime-core-reviewers for a review on PR #6278.

Wasmtime GitHub notifications bot (Apr 24 2023 at 21:12):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Apr 25 2023 at 14:47):

alexcrichton merged PR #6278.

Last updated: Dec 23 2024 at 12:05 UTC