rvolosatovs opened PR #6272 from rvolosatovs:feat/http-config
to bytecodealliance:main
:
- Remove unused variables and functions
- Consume requests and streams, rather than leaking them
- Fix timeout usage (note, that
first_byte_timeout
is never used)- Fix URI construction
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
rvolosatovs edited PR #6272:
- Remove unused variables and functions
- Consume requests and streams, rather than leaking them
- Fix timeout usage (note, that
first_byte_timeout
is never used)- Fix URI construction
Follow-up on #5929 #6228
cc @brendandburns @pchickey<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
rvolosatovs updated PR #6272.
rvolosatovs updated PR #6272.
rvolosatovs has marked PR #6272 as ready for review.
rvolosatovs requested wasmtime-core-reviewers for a review on PR #6272.
rvolosatovs requested jameysharp for a review on PR #6272.
rvolosatovs requested wasmtime-default-reviewers for a review on PR #6272.
jameysharp requested pchickey for a review on PR #6272.
rvolosatovs edited PR #6272:
Remove unused variables and functions
Fix URI construction (partially)
Follow-up on #5929 #6228
cc @brendandburns @pchickey<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
brendandburns created PR review comment:
Should we really be injecting headers on behalf of the caller?
pchickey created PR review comment:
I agree, the responsibility of setting the Host header should be on the user of this interface, rather than on the implementer.
pchickey edited PR review comment.
rvolosatovs submitted PR review.
rvolosatovs submitted PR review.
rvolosatovs created PR review comment:
I agree as well, this logic was simply moved from existing implementation, will update
rvolosatovs closed without merge PR #6272.
Last updated: Dec 23 2024 at 13:07 UTC