Wasmtime GitHub notifications bot (Apr 24 2023 at 14:41): Wasmtime GitHub notifications bot (Apr 24 2023 at 14:41):rvolosatovs opened PR #6272 from rvolosatovs:feat/http-config to bytecodealliance:main:
- Remove unused variables and functions
- Consume requests and streams, rather than leaking them
- Fix timeout usage (note, that
first_byte_timeoutis never used)- Fix URI construction
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 24 2023 at 14:42):rvolosatovs edited PR #6272:
- Remove unused variables and functions
- Consume requests and streams, rather than leaking them
- Fix timeout usage (note, that
first_byte_timeoutis never used)- Fix URI construction
Follow-up on #5929 #6228
cc @brendandburns @pchickey<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 24 2023 at 15:03):rvolosatovs updated PR #6272.
Wasmtime GitHub notifications bot (Apr 24 2023 at 15:20):rvolosatovs updated PR #6272.
Wasmtime GitHub notifications bot (Apr 24 2023 at 15:59):rvolosatovs has marked PR #6272 as ready for review.
Wasmtime GitHub notifications bot (Apr 24 2023 at 15:59):rvolosatovs requested wasmtime-core-reviewers for a review on PR #6272.
Wasmtime GitHub notifications bot (Apr 24 2023 at 15:59):rvolosatovs requested jameysharp for a review on PR #6272.
Wasmtime GitHub notifications bot (Apr 24 2023 at 15:59):rvolosatovs requested wasmtime-default-reviewers for a review on PR #6272.
Wasmtime GitHub notifications bot (Apr 24 2023 at 16:13):jameysharp requested pchickey for a review on PR #6272.
Wasmtime GitHub notifications bot (Apr 24 2023 at 18:31):rvolosatovs edited PR #6272:
Remove unused variables and functions
Fix URI construction (partially)
Follow-up on #5929 #6228
cc @brendandburns @pchickey<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 11 2023 at 20:12):brendandburns created PR review comment:
Should we really be injecting headers on behalf of the caller?
Wasmtime GitHub notifications bot (May 11 2023 at 21:15):pchickey created PR review comment:
I agree, the responsibility of setting the Host header should be on the user of this interface, rather than on the implementer.
Wasmtime GitHub notifications bot (May 11 2023 at 21:15):pchickey edited PR review comment.
Wasmtime GitHub notifications bot (May 12 2023 at 06:08):rvolosatovs submitted PR review.
Wasmtime GitHub notifications bot (May 12 2023 at 06:08):rvolosatovs submitted PR review.
Wasmtime GitHub notifications bot (May 12 2023 at 06:08):rvolosatovs created PR review comment:
I agree as well, this logic was simply moved from existing implementation, will update
Wasmtime GitHub notifications bot (Oct 19 2023 at 10:35):rvolosatovs closed without merge PR #6272.
Last updated: Nov 22 2024 at 17:03 UTC