Stream: git-wasmtime

Topic: wasmtime / PR #6266 riscv64: Support non 128bit vector sizes

Wasmtime GitHub notifications bot (Apr 22 2023 at 18:38):

afonso360 opened PR #6266 from afonso360:riscv-vec-size to bytecodealliance:main:

:wave: Hey,

This is a small follow up to #6240. This PR does a couple of things:

• We now recognize the Zvl* family of extensions, which really just specify the minimum size of a vector register.
• Instead of gating our vector lowerings on has_v and assuming 128 bit registers, we now allow lowering any size as long as they fit in a single register.
  • We switch the type extractor to ty_vec_fits_in_register which feels slightly neater than (if-let $true (has_v)) everywhere

This isn't really required, but it's neat that we get all of these lowerings without pretty much any effort, so I figured it would be worth it.

Wasmtime GitHub notifications bot (Apr 22 2023 at 18:38):

afonso360 requested fitzgen for a review on PR #6266.

Wasmtime GitHub notifications bot (Apr 22 2023 at 18:38):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #6266.

Wasmtime GitHub notifications bot (Apr 23 2023 at 11:16):

afonso360 edited PR #6266:

:wave: Hey,

This is a small follow up to #6240. This PR does a couple of things:

• We now recognize the Zvl* family of extensions, which really just specify the minimum size of a vector register.
• Instead of gating our vector lowerings on has_v and assuming 128 bit registers, we now allow lowering any size as long as they fit in a single register.
  • We switch the type extractor to ty_vec_fits_in_register which feels slightly neater than (if-let $true (has_v)) everywhere
• Also iadd uses fits_in_64 which also matches small vectors, so I switched the rules to using ty_int_ref_scalar_64 which only match scalars.

This isn't really required, but it's neat that we get all of these lowerings without pretty much any effort, so I figured it would be worth it.

Wasmtime GitHub notifications bot (Apr 24 2023 at 21:52):

afonso360 updated PR #6266.

Wasmtime GitHub notifications bot (Apr 25 2023 at 14:17):

alexcrichton submitted PR review:

Looks good to me!

Should zvl128b imply the v extension or vice-versa?

Wasmtime GitHub notifications bot (Apr 25 2023 at 15:28):

afonso360 merged PR #6266.

Last updated: Nov 22 2024 at 17:03 UTC