Wasmtime GitHub notifications bot (Apr 22 2023 at 00:18): Wasmtime GitHub notifications bot (Apr 22 2023 at 00:18):pchickey opened PR #6265 from bytecodealliance:pch/liberation to bytecodealliance:main:
No more restricting Rights. It was a failed experiment, it has effectively no adoption, and its presence in the test suite is impeding the transition to Preview 2.
All use of Rights throughout wasi-common is now removed, except for the
fs_rights_baseargument topath_openusingRIGHTS_FD_READto indicateO_RDONLYandRIGHTS_FD_WRITEto indicateO_WRONLY.All use of Rights is removed from the test suite, except for read/write. Portions of tests that check whether rights are available are deleted, only the read and write rights are ever passed, and the entire
path_open_read_without_rightstest is deleted, since its whole purpose was to measure that dropping rights worked.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 22 2023 at 00:18):pchickey requested wasmtime-core-reviewers for a review on PR #6265.
Wasmtime GitHub notifications bot (Apr 22 2023 at 00:18):pchickey requested jameysharp for a review on PR #6265.
Wasmtime GitHub notifications bot (Apr 22 2023 at 00:19):pchickey requested sunfishcode for a review on PR #6265.
Wasmtime GitHub notifications bot (Apr 27 2023 at 14:50):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Apr 27 2023 at 16:36):pchickey merged PR #6265.
Last updated: Nov 22 2024 at 17:03 UTC