Stream: git-wasmtime

Topic: wasmtime / PR #6254 fuzz: randomize block lowering order

Wasmtime GitHub notifications bot (Apr 20 2023 at 18:26):

remlse opened PR #6254 from remlse:fuzz-randomize-block-order to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

relates to #4134

The block lowering order should have no impact on correctness, so we may randomize it during fuzzing.

Wasmtime GitHub notifications bot (Apr 20 2023 at 20:03):

remlse updated PR #6254.

Wasmtime GitHub notifications bot (Apr 21 2023 at 07:31):

remlse updated PR #6254.

Wasmtime GitHub notifications bot (Apr 22 2023 at 07:23):

remlse updated PR #6254.

Wasmtime GitHub notifications bot (Apr 27 2023 at 07:40):

remlse updated PR #6254.

Wasmtime GitHub notifications bot (Apr 27 2023 at 18:58):

remlse updated PR #6254.

Wasmtime GitHub notifications bot (Apr 28 2023 at 08:41):

remlse updated PR #6254.

Wasmtime GitHub notifications bot (Apr 28 2023 at 09:55):

remlse has marked PR #6254 as ready for review.

Wasmtime GitHub notifications bot (Apr 28 2023 at 09:55):

remlse requested jameysharp for a review on PR #6254.

Wasmtime GitHub notifications bot (Apr 28 2023 at 09:55):

remlse requested wasmtime-compiler-reviewers for a review on PR #6254.

Wasmtime GitHub notifications bot (Apr 28 2023 at 09:55):

remlse requested wasmtime-default-reviewers for a review on PR #6254.

Wasmtime GitHub notifications bot (Apr 28 2023 at 16:38):

cfallin submitted PR review:

This looks great -- thanks!

Just one potential optimization below, then happy to merge.

Wasmtime GitHub notifications bot (Apr 28 2023 at 16:38):

cfallin submitted PR review:

This looks great -- thanks!

Just one potential optimization below, then happy to merge.

Wasmtime GitHub notifications bot (Apr 28 2023 at 16:38):

cfallin created PR review comment:

s/shoud/should/

Also let's reword this slightly to something like "If chaos-mode is enabled in the control plane, arbitrarily reorder ..." just to emphasize that shuffle is a no-op in the common (normal/release build) case.

Wasmtime GitHub notifications bot (Apr 28 2023 at 16:38):

cfallin created PR review comment:

Can we add an early-out conditional to shuffle along the lines of what this comment describes (if data is exhausted ...)? The effect is the same now but we construct an Unstructured, take a slice, and do some other work before we hit the break with the current code.

Wasmtime GitHub notifications bot (Apr 28 2023 at 17:47):

remlse updated PR #6254.

Wasmtime GitHub notifications bot (Apr 28 2023 at 18:01):

cfallin has enabled auto merge for PR #6254.

Wasmtime GitHub notifications bot (Apr 29 2023 at 02:01):

remlse updated PR #6254.

Wasmtime GitHub notifications bot (May 01 2023 at 16:56):

remlse updated PR #6254.

Wasmtime GitHub notifications bot (May 01 2023 at 17:08):

cfallin has enabled auto merge for PR #6254.

Wasmtime GitHub notifications bot (May 01 2023 at 20:32):

remlse updated PR #6254.

Wasmtime GitHub notifications bot (May 01 2023 at 22:28):

cfallin submitted PR review:

LGTM on latest with naming nit, thanks!

Out of curiosity, have you fuzzed with this (and verified that no issues arise)?

Wasmtime GitHub notifications bot (May 01 2023 at 22:28):

cfallin submitted PR review:

LGTM on latest with naming nit, thanks!

Out of curiosity, have you fuzzed with this (and verified that no issues arise)?

Wasmtime GitHub notifications bot (May 01 2023 at 22:28):

cfallin created PR review comment:

Let's call this shuffled(iter) or similar, perhaps? Otherwise we're using two different technical words ("shuffle" and "permutation") for method names, which seems unnecessary to me.

Wasmtime GitHub notifications bot (May 02 2023 at 07:29):

remlse updated PR #6254.

Wasmtime GitHub notifications bot (May 02 2023 at 16:58):

cfallin merged PR #6254.

Last updated: Dec 23 2024 at 12:05 UTC