Wasmtime GitHub notifications bot (Apr 19 2023 at 18:42): Wasmtime GitHub notifications bot (Apr 19 2023 at 18:42):elliottt opened PR #6246 from elliottt:trevor/riscv64-remove-gen_move2 to bytecodealliance:main:
The
gen_move2helper was only used with integer types to introduce a copy of that value. Since the move to a version of RA2 that requires SSA input, this is a no-op, and only complicates the input program. Additionally, in RA2-0.7.0 support for program moves have been removed, which means that any move present in the input program will always be present after RA2 has run.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 19 2023 at 18:45):elliottt has marked PR #6246 as ready for review.
Wasmtime GitHub notifications bot (Apr 19 2023 at 18:45):elliottt requested wasmtime-compiler-reviewers for a review on PR #6246.
Wasmtime GitHub notifications bot (Apr 19 2023 at 18:45):elliottt requested abrown for a review on PR #6246.
Wasmtime GitHub notifications bot (Apr 19 2023 at 18:51):jameysharp submitted PR review:
Ooh, very nice!
I'm curious whether the
gen_movehelper is still necessary too, but at a quick glance the five existing uses look plausibly like they might be important.
Wasmtime GitHub notifications bot (Apr 19 2023 at 21:35):elliottt merged PR #6246.
Last updated: Nov 22 2024 at 16:03 UTC