alexcrichton opened PR #6242 from alexcrichton:fix-xcompile
to bytecodealliance:main
:
This updates the
winch/codegen/build.rs
script to default to the target architecture being compiled for as opposed to the host architecture that's performing the compile.Closes #6241
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested abrown for a review on PR #6242.
alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6242.
saulecabrera submitted PR review:
Thanks for fixing this! And sorry I didn't notice the issue earlier!
saulecabrera submitted PR review:
Thanks for fixing this! And sorry I didn't notice the issue earlier!
jameysharp submitted PR review:
Do you mind adding
riscv64
ands390x
as well? Perhaps just with anelse
setting"feature=\"{target_arch}\""
if it isn't x64 or arm64, since it's only on those two targets where our feature name doesn't match the target architecture.
alexcrichton updated PR #6242.
alexcrichton has enabled auto merge for PR #6242.
alexcrichton merged PR #6242.
Last updated: Dec 23 2024 at 12:05 UTC