Stream: git-wasmtime

Topic: wasmtime / PR #6242 Fix default architecture for winch

Wasmtime GitHub notifications bot (Apr 19 2023 at 16:25):

alexcrichton opened PR #6242 from alexcrichton:fix-xcompile to bytecodealliance:main:

This updates the winch/codegen/build.rs script to default to the target architecture being compiled for as opposed to the host architecture that's performing the compile.

Closes #6241

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 19 2023 at 16:25):

alexcrichton requested abrown for a review on PR #6242.

Wasmtime GitHub notifications bot (Apr 19 2023 at 16:25):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6242.

Wasmtime GitHub notifications bot (Apr 19 2023 at 16:28):

saulecabrera submitted PR review:

Thanks for fixing this! And sorry I didn't notice the issue earlier!

Wasmtime GitHub notifications bot (Apr 19 2023 at 16:29):

saulecabrera submitted PR review:

Thanks for fixing this! And sorry I didn't notice the issue earlier!

Wasmtime GitHub notifications bot (Apr 19 2023 at 19:14):

jameysharp submitted PR review:

Do you mind adding riscv64 and s390x as well? Perhaps just with an else setting "feature=\"{target_arch}\"" if it isn't x64 or arm64, since it's only on those two targets where our feature name doesn't match the target architecture.

Wasmtime GitHub notifications bot (Apr 19 2023 at 19:27):

alexcrichton updated PR #6242.

Wasmtime GitHub notifications bot (Apr 19 2023 at 19:27):

alexcrichton has enabled auto merge for PR #6242.

Wasmtime GitHub notifications bot (Apr 19 2023 at 20:21):

alexcrichton merged PR #6242.

Last updated: Nov 22 2024 at 16:03 UTC