Stream: git-wasmtime

Topic: wasmtime / PR #6235 cranelift: Remove EBB references from...

Wasmtime GitHub notifications bot (Apr 18 2023 at 21:35):

elliottt opened PR #6235 from elliottt:trevor/remove-ebbs to bytecodealliance:main:

Remove some references in the docs to extended basic blocks, now that we've completely migrated away.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 18 2023 at 21:35):

elliottt requested abrown for a review on PR #6235.

Wasmtime GitHub notifications bot (Apr 18 2023 at 21:35):

elliottt requested wasmtime-compiler-reviewers for a review on PR #6235.

Wasmtime GitHub notifications bot (Apr 18 2023 at 21:41):

elliottt updated PR #6235.

Wasmtime GitHub notifications bot (Apr 18 2023 at 21:48):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Apr 18 2023 at 21:48):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Apr 18 2023 at 21:48):

cfallin created PR review comment:

Here we can update w.r.t. the two-target conditional branches that we now use, I think?

Wasmtime GitHub notifications bot (Apr 18 2023 at 21:56):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Apr 18 2023 at 21:56):

elliottt created PR review comment:

Good catch!

Wasmtime GitHub notifications bot (Apr 18 2023 at 21:59):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Apr 18 2023 at 21:59):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Apr 18 2023 at 21:59):

jameysharp created PR review comment:

We don't declare jump tables in the function preamble any more either, do we?

Wasmtime GitHub notifications bot (Apr 18 2023 at 22:06):

elliottt updated PR #6235.

Wasmtime GitHub notifications bot (Apr 18 2023 at 22:07):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Apr 18 2023 at 22:07):

elliottt created PR review comment:

I just removed that after noticing the same thing by @cfallin's comment :D

Wasmtime GitHub notifications bot (Apr 18 2023 at 22:08):

elliottt updated PR #6235.

Wasmtime GitHub notifications bot (Apr 18 2023 at 23:37):

elliottt merged PR #6235.

Last updated: Dec 23 2024 at 13:07 UTC