Wasmtime GitHub notifications bot (Apr 18 2023 at 19:44): Wasmtime GitHub notifications bot (Apr 18 2023 at 19:44):alexcrichton opened PR #6234 from alexcrichton:binary-literals to bytecodealliance:main:
In a number of x64-changes recently some u8 immediates are interpreted as four bit-packed 2-bit numbers and I have a tough time going between hex and these bit-packed numbers. I've been writing
0xAA == 0b...in comments to indicate the intent but I figured it'd be a bit clearer if the binary literal was accepted directly!This is a minor update to the ISLE lexer to allow for binary
0b00...and octal0o00...literals in the same manner as hex literals. Some comments in the x64 backend are then removed to use the binary literal syntax directly.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 18 2023 at 19:44):alexcrichton requested abrown for a review on PR #6234.
Wasmtime GitHub notifications bot (Apr 18 2023 at 19:44):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6234.
Wasmtime GitHub notifications bot (Apr 18 2023 at 19:59):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Apr 18 2023 at 20:00):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Apr 18 2023 at 22:48):alexcrichton updated PR #6234.
Wasmtime GitHub notifications bot (Apr 18 2023 at 22:48):alexcrichton has enabled auto merge for PR #6234.
Wasmtime GitHub notifications bot (Apr 18 2023 at 23:49):alexcrichton merged PR #6234.
Last updated: Dec 23 2024 at 12:05 UTC