Wasmtime GitHub notifications bot (Apr 18 2023 at 19:04): Wasmtime GitHub notifications bot (Apr 18 2023 at 19:04):avanhatt opened PR #6233 from avanhatt:patch-5 to bytecodealliance:main:
This keeps coming up on Zulip, so proposing some new text.
This is a documentation-only change.
Wasmtime GitHub notifications bot (Apr 18 2023 at 19:04):avanhatt requested abrown for a review on PR #6233.
Wasmtime GitHub notifications bot (Apr 18 2023 at 19:04):avanhatt requested wasmtime-compiler-reviewers for a review on PR #6233.
Wasmtime GitHub notifications bot (Apr 18 2023 at 19:09):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Apr 18 2023 at 19:09):cfallin has enabled auto merge for PR #6233.
Wasmtime GitHub notifications bot (Apr 18 2023 at 19:18):jameysharp has disabled auto merge for PR #6233.
Wasmtime GitHub notifications bot (Apr 18 2023 at 19:21):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Apr 18 2023 at 19:21):jameysharp created PR review comment:
This text is great, but I'm not sure we should use this link. At the least, I think we should link to mainline Wasmtime rather than Trevor's fork.
Also maybe we should link to whatever is on
main, rather than a specific commit. Then we can't reliably link to the specific function, but just giving the function name is probably good enough.So I think linking to
https://github.com/bytecodealliance/wasmtime/blob/main/cranelift/fuzzgen/src/function_generator.rswould be best here.
Wasmtime GitHub notifications bot (Apr 18 2023 at 19:41):avanhatt updated PR #6233.
Wasmtime GitHub notifications bot (Apr 18 2023 at 19:42):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Apr 18 2023 at 19:43):jameysharp has enabled auto merge for PR #6233.
Wasmtime GitHub notifications bot (Apr 18 2023 at 20:39):jameysharp merged PR #6233.
Last updated: Nov 22 2024 at 17:03 UTC