avanhatt opened PR #6233 from avanhatt:patch-5
to bytecodealliance:main
:
This keeps coming up on Zulip, so proposing some new text.
This is a documentation-only change.
avanhatt requested abrown for a review on PR #6233.
avanhatt requested wasmtime-compiler-reviewers for a review on PR #6233.
cfallin submitted PR review.
cfallin has enabled auto merge for PR #6233.
jameysharp has disabled auto merge for PR #6233.
jameysharp submitted PR review.
jameysharp created PR review comment:
This text is great, but I'm not sure we should use this link. At the least, I think we should link to mainline Wasmtime rather than Trevor's fork.
Also maybe we should link to whatever is on
main
, rather than a specific commit. Then we can't reliably link to the specific function, but just giving the function name is probably good enough.So I think linking to
https://github.com/bytecodealliance/wasmtime/blob/main/cranelift/fuzzgen/src/function_generator.rs
would be best here.
avanhatt updated PR #6233.
jameysharp submitted PR review.
jameysharp has enabled auto merge for PR #6233.
jameysharp merged PR #6233.
Last updated: Dec 23 2024 at 12:05 UTC