Stream: git-wasmtime

Topic: wasmtime / PR #6217 wasi-common: deprecate fd_allocate

Wasmtime GitHub notifications bot (Apr 17 2023 at 15:29):

pchickey edited PR #6217:

This removes features from WASI Preview 1 that were supported inconsistently across platforms.

We are doing so because these features never worked on windows, and can't be supported consistiently on mac and linux. They have all been removed from the WASI Preview 2 spec in progress because of these inconsistencies.

We are not aware of any real-world programs or WASI users that are broken by removing this support.

fd_allocate

This operation from cloudabi is linux-specific, isn't even supported across all linux filesystems, and has no support on macos
or windows. Rather than ship spotty support, it has been removed from preview 2, and this PR removes support for it in preview 1 as well.

The PR also removes flags from the test suite which work around this operation only being available on linux.

fd_sync and fd_datasync

The file sync operation is only supported on linux and mac, and there are different semantics on those platforms. WASI never specified the semantics of these operations, and our test suite never included use of these operations. We have removed them from preview 2, so this PR drops support in preview 1 as well.

TODO

I will also get rid of the fdflags sync flag support

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 17 2023 at 15:29):

pchickey edited PR #6217:

This removes features from WASI Preview 1 that were supported inconsistently across platforms.

We are doing so because these features never worked on windows, and can't be supported consistiently on mac and linux. They have all been removed from the WASI Preview 2 spec in progress because of these inconsistencies.

We are not aware of any real-world programs or WASI users that are broken by removing this support.

fd_allocate

This operation from cloudabi is linux-specific, isn't even supported across all linux filesystems, and has no support on macos
or windows. Rather than ship spotty support, it has been removed from preview 2, and this PR removes support for it in preview 1 as well.

The PR also removes flags from the test suite which work around this operation only being available on linux.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 17 2023 at 15:29):

pchickey has marked PR #6217 as ready for review.

Wasmtime GitHub notifications bot (Apr 17 2023 at 15:29):

pchickey requested wasmtime-core-reviewers for a review on PR #6217.

Wasmtime GitHub notifications bot (Apr 17 2023 at 15:29):

pchickey requested alexcrichton for a review on PR #6217.

Wasmtime GitHub notifications bot (Apr 17 2023 at 15:37):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Apr 17 2023 at 21:09):

sunfishcode created PR review comment:

This is still removing support for fd_sync and fd_datasync, which I think we should keep. Even though they're not portable, there is value in being able to expose what functionality the host might have to applications.

Wasmtime GitHub notifications bot (Apr 17 2023 at 21:09):

sunfishcode submitted PR review.

Wasmtime GitHub notifications bot (Apr 17 2023 at 21:14):

pchickey created PR review comment:

I got rid of that change locally but I didnt hit -f when I pushed it! Sorry.

Wasmtime GitHub notifications bot (Apr 17 2023 at 21:14):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Apr 17 2023 at 21:15):

pchickey updated PR #6217.

Wasmtime GitHub notifications bot (Apr 17 2023 at 21:23):

pchickey has enabled auto merge for PR #6217.

Wasmtime GitHub notifications bot (Apr 17 2023 at 22:10):

pchickey merged PR #6217.

Last updated: Nov 22 2024 at 16:03 UTC