Stream: git-wasmtime

Topic: wasmtime / PR #6211 For clarity in examples avoid importi...

Wasmtime GitHub notifications bot (Apr 14 2023 at 01:34):

ratmice opened PR #6211 from ratmice:main to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

As someone with barely any experience with wasm, reading through the docs and following along with the examples,
The examples which this patch modifies, both import a function hello from the host, and export one named hello from wat.

To someone looking at it for the first time, it is quite confusing which instance the string 'hello' is referring to which function.
This renames one the "host" one to the rather unimaginative host_func.

Wasmtime GitHub notifications bot (Apr 14 2023 at 01:34):

ratmice requested alexcrichton for a review on PR #6211.

Wasmtime GitHub notifications bot (Apr 14 2023 at 01:34):

ratmice requested wasmtime-core-reviewers for a review on PR #6211.

Wasmtime GitHub notifications bot (Apr 14 2023 at 15:32):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Apr 14 2023 at 16:05):

alexcrichton merged PR #6211.

Last updated: Dec 23 2024 at 13:07 UTC