Stream: git-wasmtime

Topic: wasmtime / PR #6210 Rework `only_interfaces` to the `inte...

Wasmtime GitHub notifications bot (Apr 13 2023 at 21:40):

elliottt opened PR #6210 from elliottt:trevor/rework-only-interfaces-args to bytecodealliance:main:

Allow imports to be inlined into a use of the bindgen! macro, instead of requiring a full world to be written, or world file to be referenced.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 13 2023 at 21:40):

elliottt requested alexcrichton for a review on PR #6210.

Wasmtime GitHub notifications bot (Apr 13 2023 at 21:40):

elliottt requested wasmtime-core-reviewers for a review on PR #6210.

Wasmtime GitHub notifications bot (Apr 13 2023 at 21:41):

elliottt requested pchickey for a review on PR #6210.

Wasmtime GitHub notifications bot (Apr 13 2023 at 21:42):

elliottt edited PR #6210:

Allow imports to be inlined into a use of the bindgen! macro, instead of requiring a full world to be written, or world file to be referenced. The change in syntax is that instead of referencing a world file and passing only_interfaces, you now pass just the interfaces field with the textual imports you would like to reference.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 13 2023 at 21:44):

elliottt updated PR #6210.

Wasmtime GitHub notifications bot (Apr 13 2023 at 21:45):

elliottt updated PR #6210.

Wasmtime GitHub notifications bot (Apr 13 2023 at 21:55):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Apr 13 2023 at 21:55):

pchickey has enabled auto merge for PR #6210.

Wasmtime GitHub notifications bot (Apr 13 2023 at 23:09):

pchickey merged PR #6210.

Last updated: Nov 22 2024 at 16:03 UTC