Stream: git-wasmtime

Topic: wasmtime / PR #6209 wasmtime component bindgen: when trac...

Wasmtime GitHub notifications bot (Apr 13 2023 at 21:20):

pchickey opened PR #6209 from bytecodealliance:pch/component-bindgen-tracing to bytecodealliance:main:

This is consistient with what wiggle does (see
https://github.com/bytecodealliance/wasmtime/blob/main/crates/wiggle/generate/src/funcs.rs#L266), with the exceptions that

1. wiggle has a facility for disabling tracing on a per-function basis, a requirement which was driven by functions which pass secrets into wasm. this will be added to wasmtime-wit-bindgen at a later date.
2. wiggle doesn't actually emit an event when calling a function which takes no arguments (see && func.params.len() > 0 in predicate), in this case we emit an event with the body "call", to ensure these calls are observable.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 13 2023 at 21:20):

pchickey requested alexcrichton for a review on PR #6209.

Wasmtime GitHub notifications bot (Apr 13 2023 at 21:20):

pchickey requested wasmtime-core-reviewers for a review on PR #6209.

Wasmtime GitHub notifications bot (Apr 13 2023 at 21:22):

pchickey requested elliottt for a review on PR #6209.

Wasmtime GitHub notifications bot (Apr 13 2023 at 22:01):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Apr 13 2023 at 22:17):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Apr 13 2023 at 22:17):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Apr 13 2023 at 22:17):

elliottt created PR review comment:

What do you think about always including "call" in the trace?

            uwrite!(
                self.src,
                "tracing::event!(tracing::Level::TRACE, \"call\", {});\n",

Wasmtime GitHub notifications bot (Apr 13 2023 at 22:31):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Apr 13 2023 at 22:31):

pchickey created PR review comment:

Yeah, I could do this, and always include "return" in the other side. It wouldn't hurt. That syntax isnt quite correct, though, so I'll fix it

Wasmtime GitHub notifications bot (Apr 13 2023 at 22:33):

pchickey updated PR #6209.

Wasmtime GitHub notifications bot (Apr 13 2023 at 22:34):

pchickey updated PR #6209.

Wasmtime GitHub notifications bot (Apr 13 2023 at 22:36):

pchickey has enabled auto merge for PR #6209.

Wasmtime GitHub notifications bot (Apr 13 2023 at 23:39):

pchickey merged PR #6209.

Last updated: Dec 23 2024 at 13:07 UTC