Stream: git-wasmtime

Topic: wasmtime / PR #6206 x64: Lower SIMD requirement to SSE4.1...

Wasmtime GitHub notifications bot (Apr 12 2023 at 23:14):

alexcrichton opened PR #6206 from alexcrichton:x64-no-sse42 to bytecodealliance:main:

Cranelift only has one instruction SIMD which depends on SSE4.2 so this commit adds a lowering rule for pcmpgtq which doesn't use SSE4.2 and enables lowering the baseline requirement for SIMD support from SSE4.2 to SSE4.1.

The has_sse42 setting is no longer enabled by default for Cranelift. Additionally enable_simd no longer requires has_sse42 on x64. Finally the fuzz-generator for Wasmtime codegen settings now enables flipping the has_sse42 setting instead of unconditionally setting it to true.

The specific lowering for pcmpgtq is copied from LLVM's lowering of this instruction.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 12 2023 at 23:14):

alexcrichton requested abrown for a review on PR #6206.

Wasmtime GitHub notifications bot (Apr 12 2023 at 23:14):

alexcrichton requested fitzgen for a review on PR #6206.

Wasmtime GitHub notifications bot (Apr 12 2023 at 23:14):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6206.

Wasmtime GitHub notifications bot (Apr 12 2023 at 23:14):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6206.

Wasmtime GitHub notifications bot (Apr 14 2023 at 17:24):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Apr 14 2023 at 17:24):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Apr 14 2023 at 17:24):

fitzgen created PR review comment:

Thanks for this comment, good stuff.

Wasmtime GitHub notifications bot (Apr 14 2023 at 18:04):

fitzgen merged PR #6206.

Last updated: Dec 23 2024 at 12:05 UTC