Wasmtime GitHub notifications bot (Apr 12 2023 at 19:18): Wasmtime GitHub notifications bot (Apr 12 2023 at 19:18):saulecabrera opened PR #6204 from saulecabrera:winch-x64-improve-abi-compatibility to bytecodealliance:main:
Follow up to https://github.com/bytecodealliance/wasmtime/pull/6119
This commit improves ABI support in Winch's trampolines mainly by:
- Adding support for the
fastcallcalling convention.- By storing/restoring callee-saved registers.
One of the explicit goals of this change is to make tests available in the x86_64 target as a whole and remove the need exclude the windows target.
This commit also introduces a
CallingConventionenum, to better reflect the subset of calling conventions that are supported by Winch.
prtest:full
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 13 2023 at 01:31):saulecabrera updated PR #6204.
Wasmtime GitHub notifications bot (Apr 13 2023 at 10:30):saulecabrera requested cfallin for a review on PR #6204.
Wasmtime GitHub notifications bot (Apr 13 2023 at 10:30):saulecabrera has marked PR #6204 as ready for review.
Wasmtime GitHub notifications bot (Apr 13 2023 at 10:30):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #6204.
Wasmtime GitHub notifications bot (Apr 13 2023 at 10:30):saulecabrera requested alexcrichton for a review on PR #6204.
Wasmtime GitHub notifications bot (Apr 13 2023 at 10:30):saulecabrera requested wasmtime-core-reviewers for a review on PR #6204.
Wasmtime GitHub notifications bot (Apr 13 2023 at 10:55):saulecabrera updated PR #6204.
Wasmtime GitHub notifications bot (Apr 13 2023 at 11:03):saulecabrera edited PR #6204:
Follow up to https://github.com/bytecodealliance/wasmtime/pull/6119
This commit improves ABI support in Winch's trampolines mainly by:
- Adding support for the
fastcallcalling convention.- By storing/restoring callee-saved registers.
One of the explicit goals of this change is to make tests available in the x86_64 target as a whole and remove the need exclude the windows target.
This commit also introduces a
CallingConventionenum, to better reflect the subset of calling conventions that are supported by Winch.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 13 2023 at 14:35):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Apr 14 2023 at 20:44):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Apr 14 2023 at 20:44):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Apr 14 2023 at 20:44):cfallin created PR review comment:
s/calle/callee/
Wasmtime GitHub notifications bot (Apr 14 2023 at 20:44):cfallin created PR review comment:
s/support/supporting/
Wasmtime GitHub notifications bot (Apr 14 2023 at 20:55):saulecabrera updated PR #6204.
Wasmtime GitHub notifications bot (Apr 14 2023 at 20:55):saulecabrera submitted PR review.
Wasmtime GitHub notifications bot (Apr 14 2023 at 20:55):saulecabrera created PR review comment:
Fixed, thanks!
Wasmtime GitHub notifications bot (Apr 14 2023 at 20:56):saulecabrera submitted PR review.
Wasmtime GitHub notifications bot (Apr 14 2023 at 20:56):saulecabrera created PR review comment:
Fixed, thanks!
Wasmtime GitHub notifications bot (Apr 14 2023 at 21:43):saulecabrera merged PR #6204.
Last updated: Dec 23 2024 at 13:07 UTC