Stream: git-wasmtime

Topic: wasmtime / PR #6202 Clarify the representation of `icmp` ...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 17:59):

Kmeakin opened PR #6202 from Kmeakin:icmp-documentation to bytecodealliance:main:

Add documentation to icmp clarifying the representation of true/false values for scalar and vector comparisons

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 17:59):

Kmeakin requested cfallin for a review on PR #6202.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 17:59):

Kmeakin requested wasmtime-compiler-reviewers for a review on PR #6202.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 18:27):

kevaundray submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 18:27):

kevaundray created PR review comment:

Just a formatting preference:

When comparing scalars, the result is:

- 1 if the condition holds.
- 0 if the condition does not hold.

When comparing vectors, the result is

- -1 (ie all ones) in each lane if the condition holds.
- 0 in each lane if the condition does not hold.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 18:49):

kevaundray edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 19:03):

Kmeakin updated PR #6202.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 19:47):

Kmeakin updated PR #6202.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 19:54):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 19:54):

jameysharp has enabled auto merge for PR #6202.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 20:43):

jameysharp merged PR #6202.

Last updated: Nov 22 2024 at 17:03 UTC