Stream: git-wasmtime

Topic: wasmtime / PR #6201 Fix `bitselect` => `{u,s}{min,max}` r...


view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 17:54):

Kmeakin opened PR #6201 from Kmeakin:fix-bitselect-to-minmax to bytecodealliance:main:

The rules rewriting bitselect to {u,s}{min,max} are only sound when selecting between vectors. When selecting between scalars, the result is (x & 1) | y or y.

Fixed by adding multi_lane precondition

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 17:54):

Kmeakin requested jameysharp for a review on PR #6201.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 17:54):

Kmeakin requested wasmtime-compiler-reviewers for a review on PR #6201.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 18:44):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 18:47):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 19:39):

jameysharp merged PR #6201.


Last updated: Nov 22 2024 at 16:03 UTC