Stream: git-wasmtime

Topic: wasmtime / PR #6199 Remove `unsigned_add_overflow_conditi...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 23:58):

T0b1-iOS opened PR #6199 from T0b1-iOS:rem_uadd_of_cond to bytecodealliance:main:

As mentioned in #6198 unsigned_add_overflow_condition is no longer used or makes a lot of sense otherwise.
This PR removes it.

However, there is this note in the lowering rules for s390x which I can't make sense of.
This rewriting does not seem to take place anywhere and all uses of IntCC::UnsignedGreaterThan seem normal enough.
Maybe someone with more experience in that backend can check whether this can be safely deleted, along with the comment in the lowering rules.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 23:58):

T0b1-iOS requested elliottt for a review on PR #6199.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 23:58):

T0b1-iOS requested wasmtime-compiler-reviewers for a review on PR #6199.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 23:58):

T0b1-iOS requested alexcrichton for a review on PR #6199.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 23:58):

T0b1-iOS requested wasmtime-core-reviewers for a review on PR #6199.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 04:08):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 13 2023 at 15:12):

alexcrichton merged PR #6199.

Last updated: Dec 23 2024 at 12:05 UTC